docs: fix developer guide #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
fix_developer_guide
branch
from
8dd3b1c to
b32fcfa
Compare
Drop `Source Code` section, as it contains an outdated guideline with respect to documenting changes and its contents are already covered by other sections.
|
This more or less looks good to me, though should we maybe link to the github documentation on making a PR or something like it? It's hard for me to judge how much knowledge we're assuming on the part of new contributors here. |
Yes, perhaps. Let's accept this and await further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Drop
Source Codesection, as it contains an outdated guideline with respect to documenting changes and its contents are already covered by other sections.Pull Request Checklist