New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix developer guide #1403

Merged
merged 2 commits into from Jul 1, 2018

Conversation

Projects
None yet
3 participants
@benoit-pierre
Member

benoit-pierre commented Jun 28, 2018

Summary of changes

Drop Source Code section, as it contains an outdated guideline with respect to documenting changes and its contents are already covered by other sections.

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:fix_developer_guide branch from 8dd3b1c to b32fcfa Jun 28, 2018

benoit-pierre added some commits Jun 20, 2018

docs: fix developer guide
Drop `Source Code` section, as it contains an outdated guideline
with respect to documenting changes and its contents are already
covered by other sections.
@pganssle

This comment has been minimized.

Member

pganssle commented Jun 29, 2018

This more or less looks good to me, though should we maybe link to the github documentation on making a PR or something like it? It's hard for me to judge how much knowledge we're assuming on the part of new contributors here.

@jaraco

This comment has been minimized.

Member

jaraco commented Jul 1, 2018

should we maybe link

Yes, perhaps. Let's accept this and await further improvements.

@jaraco jaraco merged commit 244ff32 into pypa:master Jul 1, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 5c81648...b32fcfa
Details
codecov/project 80.99% remains the same compared to 5c81648
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_developer_guide branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment