New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PEP 518 configuration #1404

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
2 participants
@benoit-pierre
Member

benoit-pierre commented Jun 28, 2018

Summary of changes

Add build-system.requires key to pyproject.toml:

  • this is necessary with pip 10.0.1, as otherwise the defaults will be to require both setuptools and wheel (and we only need the later)
  • a pyproject.toml with no build-system.requires key will be invalid and rejected by a future version of pip (see pypa/pip#5416 (comment))

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:fix_pyproject.toml branch from 7686079 to 601f82e Jun 28, 2018

fix PEP 518 configuration
Add `build-system.requires` key to `pyproject.toml`:
- this is necessary with pip 10.0.1, as otherwise the defaults will be
  to require both `setuptools` and `wheel` (and we only need the later)
- a `pyproject.toml` with no `build-system.requires` key will be invalid
  and rejected by a future version of pip
  (see pypa/pip#5416 (comment))
@pganssle

This comment has been minimized.

Member

pganssle commented Jun 29, 2018

LGTM.

@pganssle pganssle merged commit a94ccbf into pypa:master Jun 29, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 5c81648...601f82e
Details
codecov/project 80.99% remains the same compared to 5c81648
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_pyproject.toml branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment