Egg race condition #1418
Merged
Egg race condition #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
egg_race_condition
branch
from
16ab345
to
07eb87f
Compare
2 tasks
|
Thanks for tackling this, I appreciate it! +1 from me |
pganssle
force-pushed
the
egg_race_condition
branch
from
07eb87f
to
e36c32d
Compare
This mocks out the isdir call so that the directory is created immediately after you determine whether or not it exists, thus simulating a race condition between two threads or processes creating the same directory.
This fixes a race condition in _bypass_ensure_directory where two threads or processes may erroneously fail because they are both creating the same directory. A more robust implementation of this may involve exposing the un-wrapped os.makedirs. Originally reported with proposed patch by @JonKohler in github PR pypa#1412. This patch came out of discussions on that thread.
pganssle
force-pushed
the
egg_race_condition
branch
from
601217f
to
67f190a
Compare
|
Where are we at on this? is there anything remaining? Does this replace my original PR? |
|
Yes this should replace your original PR since it solves the same problem in a different way. I've seen no objections since I opened this PR so I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR is an approach to #1412 that adds a test to induce this race condition. The test relies on implementation details, but that is made explicit in the text of the test, I have done it this way because there isn't another great way to deterministically induce the problem.
cc: @JonKohler
Closes #1256
Pull Request Checklist