Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious executable permissions #1441

Merged
merged 1 commit into from Jul 27, 2018
Merged

Remove spurious executable permissions #1441

merged 1 commit into from Jul 27, 2018

Conversation

@hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 27, 2018

Summary of changes

Remove spurious executable permissions from files that don't need them.

Pull Request Checklist

  • Changes have tests (not really, but I really doubt the usefulness)
  • News fragment added in changelog.d.
@hroncok hroncok force-pushed the hroncok:chmodx branch from a22e388 to cf080b0 Jul 27, 2018
@jaraco
Copy link
Member

@jaraco jaraco commented Jul 27, 2018

This change seems useful. Should we give the same treatment to the other files in the root of the project?

@jaraco
Copy link
Member

@jaraco jaraco commented Jul 27, 2018

And probably all files in the project that don't need to be executable. I see executable bits on, for example, setuptools/namespaces.py.

@hroncok
Copy link
Contributor Author

@hroncok hroncok commented Jul 27, 2018

launcher.c, pytest.ini, ok, I'll try to get them all.

@hroncok hroncok changed the title Remove spurious executable permission from README WIP: Remove spurious executable permissions Jul 27, 2018
@hroncok hroncok force-pushed the hroncok:chmodx branch from cf080b0 to 760e2e1 Jul 27, 2018
@hroncok hroncok changed the title WIP: Remove spurious executable permissions Remove spurious executable permissions Jul 27, 2018
@hroncok
Copy link
Contributor Author

@hroncok hroncok commented Jul 27, 2018

Amended.

@jaraco
Copy link
Member

@jaraco jaraco commented Jul 27, 2018

Excellent. Thanks!

@jaraco jaraco merged commit e0433cf into pypa:master Jul 27, 2018
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing e2dde5b...760e2e1
Details
codecov/project 81.17% remains the same compared to e2dde5b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@hroncok hroncok deleted the hroncok:chmodx branch Jul 27, 2018
@pganssle pganssle mentioned this pull request Aug 19, 2018
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants