New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vendored appdirs from 1.4.0 to 1.4.3 #1451

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@hugovk
Contributor

hugovk commented Aug 9, 2018

Summary of changes

Fixes the second part of #1095 and #1450 (see #1450 for the first part).

Upgrade vendored appdirs from 1.4.0 to 1.4.3 to remove deprecation warnings:

master

$ python3 --version
Python 3.7.0
$ find . -name \*.py | xargs python3 -Wall -m py_compile
./setuptools/_vendor/pyparsing.py:147: DeprecationWarning: invalid escape sequence \d
  xmlcharref = Regex('&#\d+;')
./setuptools/_vendor/pyparsing.py:832: DeprecationWarning: invalid escape sequence \d
  """
./setuptools/_vendor/pyparsing.py:2736: DeprecationWarning: invalid escape sequence \d
  """
./setuptools/_vendor/pyparsing.py:2914: DeprecationWarning: invalid escape sequence \g
  ret = re.sub(self.escCharReplacePattern,"\g<1>",ret)
./pkg_resources/_vendor/appdirs.py:130: DeprecationWarning: invalid escape sequence \D
  """
./pkg_resources/_vendor/appdirs.py:235: DeprecationWarning: invalid escape sequence \P
  """
./pkg_resources/_vendor/pyparsing.py:147: DeprecationWarning: invalid escape sequence \d
  xmlcharref = Regex('&#\d+;')
./pkg_resources/_vendor/pyparsing.py:832: DeprecationWarning: invalid escape sequence \d
  """
./pkg_resources/_vendor/pyparsing.py:2736: DeprecationWarning: invalid escape sequence \d
  """
./pkg_resources/_vendor/pyparsing.py:2914: DeprecationWarning: invalid escape sequence \g
  ret = re.sub(self.escCharReplacePattern,"\g<1>",ret)

This PR

$ python3 --version
Python 3.7.0
$ find . -name \*.py | xargs python3 -Wall -m py_compile
./setuptools/_vendor/pyparsing.py:147: DeprecationWarning: invalid escape sequence \d
  xmlcharref = Regex('&#\d+;')
./setuptools/_vendor/pyparsing.py:832: DeprecationWarning: invalid escape sequence \d
  """
./setuptools/_vendor/pyparsing.py:2736: DeprecationWarning: invalid escape sequence \d
  """
./setuptools/_vendor/pyparsing.py:2914: DeprecationWarning: invalid escape sequence \g
  ret = re.sub(self.escCharReplacePattern,"\g<1>",ret)
./pkg_resources/_vendor/pyparsing.py:147: DeprecationWarning: invalid escape sequence \d
  xmlcharref = Regex('&#\d+;')
./pkg_resources/_vendor/pyparsing.py:832: DeprecationWarning: invalid escape sequence \d
  """
./pkg_resources/_vendor/pyparsing.py:2736: DeprecationWarning: invalid escape sequence \d
  """
./pkg_resources/_vendor/pyparsing.py:2914: DeprecationWarning: invalid escape sequence \g

Pull Request Checklist

  • Changes have tests: existing tests still pass
  • News fragment added in changelog.d. See documentation for details
@pganssle

This comment has been minimized.

Member

pganssle commented Aug 17, 2018

@hugovk Should we go all the way to 1.4.4?

@pganssle

This comment has been minimized.

Member

pganssle commented Aug 17, 2018

Oh my mistake, 1.4.4 is not released yet, it's only on master.

@pganssle pganssle force-pushed the hugovk:upgrade-appdirs branch from f06b08f to 993f6d8 Aug 17, 2018

@pganssle pganssle merged commit 85593de into pypa:master Aug 17, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 336ff3a...993f6d8
Details
codecov/project 81.2% remains the same compared to 336ff3a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@hugovk hugovk deleted the hugovk:upgrade-appdirs branch Aug 17, 2018

@pganssle

This comment has been minimized.

Member

pganssle commented Aug 17, 2018

@hugovk Thanks much for your contributions here and in #1450!

@hugovk

This comment has been minimized.

Contributor

hugovk commented Aug 17, 2018

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment