Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools: fix regression with egg_info command #1465

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented Aug 20, 2018

Ensure version is tagged only once. Fix #1462.

@jaraco
Copy link
Member

@jaraco jaraco commented Aug 20, 2018

Thank you, especially for the regression test. Nicely done.

Loading

@benoit-pierre
Copy link
Member Author

@benoit-pierre benoit-pierre commented Aug 21, 2018

Off-topic: I think the fact that I need to create the PR before I can update it with a towncrier entry (because I need the PR number) really annoying. Don't know how to improve the workflow though...

Loading

Ensure version is tagged only once.
@benoit-pierre benoit-pierre force-pushed the fix_egg_info_regression branch from a6a2c27 to 337c008 Aug 21, 2018
@jaraco jaraco merged commit 5f4fa26 into pypa:master Aug 21, 2018
5 checks passed
Loading
@pganssle
Copy link
Member

@pganssle pganssle commented Aug 21, 2018

@benoit-pierre Agreed, that's one of my biggest pet peeves with town crier.

For some background, town crier came out of Twisted, which has a much more formal process for contributions. For both Twisted and CPython, every PR must have an associated ticket in the bug tracker, and that's the number that's supposed to go in the changelog.

I think we were never quite so formal about it because we wanted people to be able to do drive-by PRs without an associated issue. If we want to alleviate the issue (which I agree is a pain), I see two ways forward:

  1. All PRs must have an associated issue, and the news fragment is numbered by issue.
  2. Change the workflow so that you can commit a file called #PR_STUB#.change.rst in the changelog.d, and we write a bot to update the PR when a number becomes available.

Loading

@benoit-pierre benoit-pierre deleted the fix_egg_info_regression branch Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants