Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add futures and backport to Python 2.7 test requirements #1572

Merged
merged 2 commits into from Nov 4, 2018

Conversation

@pganssle
Copy link
Member

@pganssle pganssle commented Nov 3, 2018

setuptools.tests.test_build_meta relies on the Python 3 feature concurrent.futures to run, and as a result has been silently skipped in Python 2.7. This adds the futures backport to the 2.7 test requirements and turns the pytest.importorskip invocations in test_build_meta into standard import statements.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
pganssle added a commit to pganssle/setuptools that referenced this pull request Nov 3, 2018
pganssle added 2 commits Nov 3, 2018
`setuptools.tests.test_build_meta` relies on the Python 3 feature
`concurrent.futures` to run, and as a result has been silently skipped
in Python 2.7. This adds the `futures` backport to the 2.7 test
requirements and turns the `pytest.importorskip` invocations in test_build_meta
into standard import statements.
@pganssle pganssle force-pushed the pganssle:import_futures_test_reqs branch from bfbd607 to b2cbe86 Nov 3, 2018
@pganssle pganssle changed the title Add futures and importlib backports to test reqs Add futures and backport to Python 2.7 test requirements Nov 3, 2018
@pganssle pganssle merged commit b0c7466 into pypa:master Nov 4, 2018
5 checks passed
5 checks passed
@codecov
codecov/patch 100% of diff hit (target 81.65%)
Details
@codecov
codecov/project 81.69% (+0.03%) compared to 6ed6fe8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@djhoese
Copy link

@djhoese djhoese commented Nov 7, 2018

Any idea if this fixes the python 2 backport of futures being installed on a python 3 environment? I'm planning on filing a bug report for it, but am still testing what is going on and what may fix it. Looks like with setuptools 40.5, it is installing futures on python 3 environments.

https://travis-ci.org/pytroll/satpy/jobs/451521185#L947

@pganssle
Copy link
Member Author

@pganssle pganssle commented Nov 7, 2018

This PR only affects the setuptools tests, so it shouldn't change anything for users of setuptools.

@pganssle pganssle deleted the pganssle:import_futures_test_reqs branch Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants