New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In build_meta (PEP 517), always built gztar #1625

Merged
merged 4 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@jaraco
Copy link
Member

jaraco commented Jan 2, 2019

Summary of changes

Always build gztar in build_meta

Closes #1623

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

jaraco added some commits Jan 2, 2019

Always specify formats=gztar, overriding the project's legacy expecta…
…tion that a zip sdist should be generated. Fixes #1623.

@jaraco jaraco closed this Jan 2, 2019

@jaraco jaraco reopened this Jan 2, 2019

@jaraco jaraco requested review from benoit-pierre and takluyver Jan 2, 2019

@jaraco

This comment has been minimized.

Copy link
Member Author

jaraco commented Jan 2, 2019

Apologies that 2db2a8 shows up in the PR - I've since pushed that commit to master, but it's sticky here.

@takluyver
Copy link
Member

takluyver left a comment

As I mentioned on the other PR, I think it might be necessary to build to a temporary directory and then move the file, but that's a separate issue from this PR.

@jaraco jaraco merged commit 572fb15 into master Jan 3, 2019

7 checks passed

codecov/patch 100% of diff hit (target 82.37%)
Details
codecov/project 82.37% (+<.01%) compared to f4eb139
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment