Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In build_meta (PEP 517), always built gztar #1625

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jan 2, 2019

Summary of changes

Always build gztar in build_meta

Closes #1623

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

@jaraco jaraco closed this Jan 2, 2019
@jaraco jaraco reopened this Jan 2, 2019
@jaraco
Copy link
Member Author

jaraco commented Jan 2, 2019

Apologies that 2db2a8 shows up in the PR - I've since pushed that commit to master, but it's sticky here.

Copy link
Member

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on the other PR, I think it might be necessary to build to a temporary directory and then move the file, but that's a separate issue from this PR.

@jaraco jaraco merged commit 572fb15 into master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants