Skip to content

/ setuptools Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer native strings on Python 2 when reading config files. #1660

Merged
merged 3 commits into from Jan 29, 2019
Merged

Prefer native strings on Python 2 when reading config files. #1660

merged 3 commits into from Jan 29, 2019

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Jan 28, 2019 •
edited

Summary of changes

Closes #1653

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d.
@jaraco jaraco changed the base branch from master to 40.7-maintenance Jan 28, 2019
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 28, 2019

My intention is to release this as a commit against v40.7.0 as v40.7.1 without the other commits currently on master.

@benoit-pierre benoit-pierre mentioned this pull request Jan 28, 2019
Closed
benoit-pierre and others added 3 commits Jan 28, 2019
@benoit-pierre @jaraco
test: add a simple regression test for `build_ext`
f744781
@jaraco
Prefer native strings on Python 2 when reading config files. Fixes #1653
9150b6b 
.
@jaraco
Add changelog
32c2ec8
@jaraco jaraco force-pushed the bugfix/1653-downcast-config-strings branch from f9a6dd6 to 32c2ec8 Jan 28, 2019
@jaraco jaraco force-pushed the 40.7-maintenance branch from f744781 to 78fd730 Jan 28, 2019
@jaraco jaraco closed this Jan 28, 2019
@jaraco jaraco reopened this Jan 28, 2019
@ofek
Copy link
Contributor

@ofek ofek commented Jan 29, 2019

Will the release happen tonight?

@jaraco jaraco merged commit c3a8b67 into 40.7-maintenance Jan 29, 2019
6 checks passed
@jaraco jaraco deleted the bugfix/1653-downcast-config-strings branch Jan 29, 2019
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 29, 2019

40.7.1 should be releasing here momentarily

@ofek
Copy link
Contributor

@ofek ofek commented Jan 29, 2019

Many thanks!

@kevinoid kevinoid mentioned this pull request Oct 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jaraco @ofek @benoit-pierre