Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: git and hg revision checkout under Windows #1741

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@2xB
Copy link
Contributor

commented Apr 11, 2019

Windows does not change the working directory for a process via cd .. && <process> (see e.g. this question: https://stackoverflow.com/q/55641332/8575607 ). This commit replaces the use of (cd %s && <command>) with arguments provided by git and hg respectively.

Closes #1740

2xB and others added some commits Apr 11, 2019

FIX: git and hg revision checkout under Windows
Windows does not change the working directory for a process via `cd .. && <process>` (see e.g. this question: https://stackoverflow.com/q/55641332/8575607 ). This commit replaces the use of `cd .. &&` with arguments provided by `git` and `hg` respectively.
Updated test to check for changed git rev checkout
Checking for new implementation solving issue #1740

@jaraco jaraco merged commit 1cc8821 into pypa:master Apr 12, 2019

1 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
Mergify — Summary 1 potential rule
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.