Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_meta: fix 2 issues with `build_wheel` / `build_sdist` #1750

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@benoit-pierre
Copy link
Member

commented Apr 22, 2019

Summary of changes

Fix the following cases:

  • build_sdist is called with another sdist already present in the destination directory (#1749)

  • build_wheel is called with the destination directory not already created

Closes #1749.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
build_meta: fix 2 issues with `build_wheel` / `build_sdist`
Fix the following cases:

* `build_sdist` is called with another sdist already present
  in the destination directory

* `build_wheel` is called with the destination directory not
  already created

benoit-pierre added a commit to benoit-pierre/setuptools that referenced this pull request Apr 22, 2019

@pganssle pganssle force-pushed the benoit-pierre:fix_1749 branch from ddafb4f to 812a97c Apr 23, 2019

@pganssle
Copy link
Member

left a comment

I cleaned up the news entry and actually split it into two entries, because I think it makes sense to keep them separate in the final changelog.

This looks good to me now, setting for automerge.

@pganssle pganssle added the auto-merge label Apr 23, 2019

@mergify mergify bot merged commit 83c667e into pypa:master Apr 24, 2019

6 checks passed

Mergify — Summary 1 rule matches
Details
codecov/patch 100% of diff hit (target 83.16%)
Details
codecov/project 83.16% (+<.01%) compared to 97d7563
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_1749 branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.