Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve Visual C++ 14.X support #1811
Summary of changes
Tested on Windows 10 with Python 3.7.4 and "Visual Studio Build Tools 2019" with following setup cases:
This setuptools file cover a wide variety of VS configurations that I cannot test easily. So any code review and other tests are really welcome.
There is no automated tests for this. This setuptools part did not really had tests before this PR, and it may be very hard to do real relevant automated tests for it.
Pull Request Checklist
Improve VC++14 support for VS 2017 and 2019. Separate VC from VS version (Miss match starting VS15). Improve docstrings args and returns information + fixe typos. Fix coding style and minor coding issues. Remove Microsoft "Windows SDK 7.0" dead link.
Concerning the evolution of this file (
The majority of the code was written to support some VC9 & VC10 old compilers that does not really had a
So, in the end of this year, this file can be easily simplified to remove almost all its content and only keep a Python 3.5/VC compat part that will be kept until Python 3.5 deprecation.
Hi! There is a change in this PR that breaks Python 2: https://github.com/pypa/setuptools/pull/1811/files#diff-ebddaa1b649ef567c2534a012ba25913R627
with open(state_path, 'rt', encoding='utf-8') as state_file:
Is it intentional?