Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel: switch to packaging.tags for checking PEP 425 tags #1829

Merged
merged 3 commits into from Nov 17, 2019

Conversation

benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented Aug 23, 2019

Summary of changes

Update setuptools vendored packaging so the wheel code can be switched to packaging.tags for checking PEP 425 tags compatibility.

Supersede #1822.

Closes #1799.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

@benoit-pierre
Copy link
Member Author

@benoit-pierre benoit-pierre commented Aug 23, 2019

WIP until a new version of packaging including pypa/packaging#179 is released.

@benoit-pierre
Copy link
Member Author

@benoit-pierre benoit-pierre commented Oct 7, 2019

Updated now that packaging 19.2 has been released and ready for merge.

@benoit-pierre benoit-pierre marked this pull request as ready for review Oct 7, 2019
@benoit-pierre benoit-pierre reopened this Nov 15, 2019
@jaraco jaraco merged commit e31c9f0 into pypa:master Nov 17, 2019
6 checks passed
skye added a commit to skye/jax that referenced this issue Aug 14, 2020
1. `wheel.pep425tags` has been removed as of
   pypa/setuptools#1829. Use the new
   `packaging.tags` instead.

2. Add `--allow-downgrades` to cuda install command. I'm not sure this
   is always necessary, but I ran into it, I'm guessing due to a cached
   docker image.
skye added a commit to google/jax that referenced this issue Sep 9, 2020
1. `wheel.pep425tags` has been removed as of
   pypa/setuptools#1829. Use the new
   `packaging.tags` instead.

2. Add `--allow-downgrades` to cuda install command. I'm not sure this
   is always necessary, but I ran into it, I'm guessing due to a cached
   docker image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants