Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel: switch to `packaging.tags` for checking PEP 425 tags #1829

Merged
merged 3 commits into from Nov 17, 2019

Conversation

@benoit-pierre
Copy link
Member

benoit-pierre commented Aug 23, 2019

Summary of changes

Update setuptools vendored packaging so the wheel code can be switched to packaging.tags for checking PEP 425 tags compatibility.

Supersede #1822.

Closes #1799.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@benoit-pierre benoit-pierre added the draft label Aug 23, 2019
@benoit-pierre

This comment has been minimized.

Copy link
Member Author

benoit-pierre commented Aug 23, 2019

WIP until a new version of packaging including pypa/packaging#179 is released.

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:update_pep425tags branch from 2c3941a to 0744f7b Oct 7, 2019
@benoit-pierre benoit-pierre removed the draft label Oct 7, 2019
@benoit-pierre

This comment has been minimized.

Copy link
Member Author

benoit-pierre commented Oct 7, 2019

Updated now that packaging 19.2 has been released and ready for merge.

@benoit-pierre benoit-pierre marked this pull request as ready for review Oct 7, 2019
@benoit-pierre benoit-pierre reopened this Nov 15, 2019
@jaraco jaraco merged commit e31c9f0 into pypa:master Nov 17, 2019
6 checks passed
6 checks passed
Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 84.74%)
Details
codecov/project 85.55% (+0.81%) compared to 734d09c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@benoit-pierre benoit-pierre mentioned this pull request Nov 25, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.