Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for Python 3.8 through a trove classifier #1884

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@jdufresne
Copy link
Contributor

jdufresne commented Oct 22, 2019

Travis has official support for the Python 3.8 release, so can use that instead of 3.8-dev.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@jdufresne jdufresne force-pushed the jdufresne:py38 branch from 791446b to 3f6e3cf Oct 22, 2019
@pganssle

This comment has been minimized.

Copy link
Member

pganssle commented Oct 22, 2019

@jdufresne Can we move the change to the Travis support to a different PR? I think we still want to test against a dev version of Python, and we may want to make other changes. The 3.8-dev branch still tests against 3.8, just the development head rather than the stable release, so I think it's fair to claim 3.8 support anyway.

changelog.d/1884.doc.rst Outdated Show resolved Hide resolved
@jdufresne jdufresne force-pushed the jdufresne:py38 branch from 3f6e3cf to e4ef537 Oct 22, 2019
@jdufresne

This comment has been minimized.

Copy link
Contributor Author

jdufresne commented Oct 22, 2019

Done. I'll open a new PR for the Travis change.

@pganssle pganssle merged commit 297f2ad into pypa:master Oct 23, 2019
6 checks passed
6 checks passed
Summary 1 potential rule
Details
codecov/patch Coverage not affected when comparing d0460f8...e4ef537
Details
codecov/project 84.79% remains the same compared to d0460f8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@jdufresne jdufresne deleted the jdufresne:py38 branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.