Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "upload" and "register" commands. #1898

Merged
merged 1 commit into from Nov 3, 2019

Conversation

@pganssle
Copy link
Member

pganssle commented Oct 31, 2019

Summary of changes

The upload and register commands were deprecated over a year ago, in July 2018 (PR #1410, discussed in issue #1381). It is time to actively remove them in favor of twine.

I think the most controversial part of this might be that I've added setuptools.errors. It wasn't clear what the best error class to use would be. distutils will use raise SystemExit for a missing command; that didn't seem quite like the right thing to do, but I'm willing to be convinced otherwise.

CC @pypa/setuptools-developers @di

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@pganssle pganssle force-pushed the pganssle:remove_upload_register branch from 04a8273 to c0bbd62 Oct 31, 2019
@di
di approved these changes Oct 31, 2019
Copy link
Member

di left a comment

(deprecated over a year ago, in July 2018)

I think we could be a little more helpful with the docs but otherwise LGTM.

docs/setuptools.txt Show resolved Hide resolved
@jaraco
jaraco approved these changes Oct 31, 2019
@pganssle pganssle force-pushed the pganssle:remove_upload_register branch 4 times, most recently from 1995daf to e5b43bd Nov 1, 2019
@pganssle

This comment has been minimized.

Copy link
Member Author

pganssle commented Nov 2, 2019

Oops, turns out that if you name your classes UploadTest instead of TestUpload it doesn't get detected by pytest. I guess that's why they were originally named Test(Upload|Register)Test...

Yet another time when I am appreciative that we include the tests in the coverage, and that we enforce diff coverage...

@pganssle pganssle force-pushed the pganssle:remove_upload_register branch from e5b43bd to 7703937 Nov 2, 2019
The upload and register commands were deprecated over a year ago, in
July 2018 (PR GH-1410, discussed in issue GH-1381). It is time to
actively remove them in favor of twine.
@pganssle pganssle force-pushed the pganssle:remove_upload_register branch from 7703937 to f413f95 Nov 2, 2019
@pganssle

This comment has been minimized.

Copy link
Member Author

pganssle commented Nov 3, 2019

OK, merging this, which means that next release should be a breaking one!

@pganssle pganssle merged commit 5af71d2 into pypa:master Nov 3, 2019
6 checks passed
6 checks passed
Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 84.69%)
Details
codecov/project Absolute coverage decreased by -0.15% but relative coverage increased by +15.3% compared to 6ac7b4e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.