Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel: fix `is_compatible` implementation #1918

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@benoit-pierre
Copy link
Member

benoit-pierre commented Nov 25, 2019

Summary of changes

Fix Wheel.is_compatible implementation, which I bungled in #1829.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@benoit-pierre benoit-pierre force-pushed the benoit-pierre:fix_wheel_tags_handling branch from c5077b2 to 926c80f Nov 25, 2019
@benoit-pierre benoit-pierre merged commit 3287006 into pypa:master Nov 25, 2019
6 checks passed
6 checks passed
Summary 1 potential rule
Details
codecov/patch 100% of diff hit (target 84.99%)
Details
codecov/project Absolute coverage decreased by -0.73% but relative coverage increased by +15% compared to d155aa0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_wheel_tags_handling branch Nov 25, 2019
@benoit-pierre

This comment has been minimized.

Copy link
Member Author

benoit-pierre commented Nov 25, 2019

Released in 42.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.