Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for easy_install's find-links option in setup.cfg #1921

Merged

Conversation

@benoit-pierre
Copy link
Member

benoit-pierre commented Nov 26, 2019

Summary of changes

The easy_install's find-links option can sometime be a string (and not a list of string), e.g. when its value comes from setup.cfg (see handling in easy_install own code).

Ensure it's similarly handled in fetch_build_egg.

Closes #1920, #1375, and probably #1880.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@benoit-pierre benoit-pierre force-pushed the benoit-pierre:fix_handling_of_find-links_in_setup.cfg branch from fda130b to 6f46a4b Nov 26, 2019
@jaraco jaraco merged commit a8d9568 into pypa:master Dec 1, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Summary 1 potential rule
Details
deploy/netlify Deploy preview ready!
Details
@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_handling_of_find-links_in_setup.cfg branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.