Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make easy_install command less strict (fixes #1405) #1941

Merged
merged 3 commits into from Feb 6, 2020
Merged

Make easy_install command less strict (fixes #1405) #1941

merged 3 commits into from Feb 6, 2020

Conversation

joreiff
Copy link
Contributor

@joreiff joreiff commented Dec 19, 2019

Summary of changes

This PR implements the changes proposed in issue #1405:

  • The --user option is always available. A warning is issued if the user site directory is not available.
  • The error shown when the install directory is not in PYTHONPATH has been turned into a warning.

Closes #1405

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

Discussion

We should probably adapt the message when the install directory is not on PYTHONPATH since it is no longer a hard error. Any opinions?

Also, this is my first PR for setuptools, so I am interested in feedback as well as guidance on how/where to implement the tests. Would TestEasyInstallTest from setuptools/tests/test_easy_install.py be appropriate?

@joreiff joreiff marked this pull request as ready for review Dec 19, 2019
@joreiff
Copy link
Contributor Author

@joreiff joreiff commented Feb 5, 2020

Is there any interest in this PR? According to #1405, there seems to be a consensus about the approach taken here. Since this issue is preventing me from adopting PEP 517/518 projects more widely, I would appreciate some feedback.

@Qu4tro
Copy link

@Qu4tro Qu4tro commented Feb 5, 2020

I'm interested. Been watching this PR since it was submitted.

I don't have much to add other than the current status is quite a hurdle on our project. The tradeoffs for the workarounds are not great.

For what is worth PR lgtm.

@jaraco jaraco merged commit 757deb1 into pypa:master Feb 6, 2020
9 of 24 checks passed
@joreiff
Copy link
Contributor Author

@joreiff joreiff commented Feb 6, 2020

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants