Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Mac OS X -> macOS #2062

Merged
merged 4 commits into from May 3, 2020
Merged

change: Mac OS X -> macOS #2062

merged 4 commits into from May 3, 2020

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Apr 11, 2020

Signed-off-by: Reece Dunham me@rdil.rocks

Summary of changes

OS X isn't what macOS is called anymore. This fixes it.

A couple other small fixes included aswell related.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

RDIL added 4 commits Apr 11, 2020
@@ -1519,7 +1519,7 @@ v21.1.0
* #572: In build_ext, now always import ``_CONFIG_VARS``
from ``distutils`` rather than from ``sysconfig``
to allow ``distutils.sysconfig.customize_compiler``
configure the OS X compiler for ``-dynamiclib``.
Copy link
Member

@jaraco jaraco May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to change the entries in the changelog? After all, at the time, it was called OS X.

@@ -365,7 +365,7 @@ def get_provider(moduleOrReq):
return _find_adapter(_provider_factories, loader)(module)


def _macosx_vers(_cache=[]):
def _macos_vers(_cache=[]):
Copy link
Member

@jaraco jaraco May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, let's rename these to _macOS_vers. I prefer to honor the casing when possible.

@@ -8,10 +8,9 @@
See <http://github.com/ActiveState/appdirs> for details and usage.
"""
# Dev Notes:
# - MSDN on where to store app data files:
Copy link
Member

@jaraco jaraco May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert anything in _vendor. These files are maintained upstream. You'll want to contribute this change to the upstream package.

Copy link
Member

@jaraco jaraco left a comment

I appreciate you making this change. Just want to be less aggressive about it. After reverting the changes to CHANGES.rst and _vendor/**, it's good to go.

jaraco added a commit that referenced this issue May 3, 2020
@jaraco jaraco merged commit 63b03e3 into pypa:master May 3, 2020
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants