Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry point scripts #2195

Merged
merged 2 commits into from Jun 15, 2020
Merged

Fix entry point scripts #2195

merged 2 commits into from Jun 15, 2020

Conversation

ofek
Copy link
Sponsor Contributor

@ofek ofek commented Jun 15, 2020

Summary of changes

Fix to #2194 @jaraco

Is there a better way to inject just the package name? I thought that is what spec was.

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.3/x64/bin/ddev", line 9, in <module>
    for entry_point in distribution('datadog-checks-dev==3.11.0').entry_points:
  File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/importlib/metadata.py", line 504, in distribution
    return Distribution.from_name(distribution_name)
  File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/importlib/metadata.py", line 177, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: datadog-checks-dev==3.11.0

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

Copy link

@cooperlees cooperlees left a comment

Many thanks for this fix. Just a thought on the test side. Pretty common use case I feel.

setuptools/command/easy_install.py Show resolved Hide resolved
@jaraco jaraco merged commit 1d841d7 into pypa:master Jun 15, 2020
21 of 24 checks passed
@ofek ofek deleted the fix branch Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants