Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception causes all over the codebase #2199

Merged
merged 2 commits into from Jul 3, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 16, 2020

This is a continuation of #2189 .

@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch 2 times, most recently from 6d31fbc to d0d2f8c Compare Jun 16, 2020
@cool-RR cool-RR marked this pull request as ready for review Jun 21, 2020
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 21, 2020

@jaraco Looks like I forgot to mark this as "ready for review", I did that now.

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 28, 2020

@jaraco Nudge

jaraco
jaraco approved these changes Jun 28, 2020
setuptools/dist.py Show resolved Hide resolved
Copy link
Member

@jaraco jaraco left a comment

Can you add a changelog entry?

@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch from d0d2f8c to a9eb9e7 Compare Jun 28, 2020
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 28, 2020

Fixed.

jaraco
jaraco approved these changes Jul 3, 2020
@jaraco jaraco merged commit 990237c into pypa:master Jul 3, 2020
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants