Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Replace 3.9 beta with 3.9 final #2420

Merged
merged 4 commits into from Oct 17, 2020
Merged

GHA: Replace 3.9 beta with 3.9 final #2420

merged 4 commits into from Oct 17, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 12, 2020

Summary of changes

The CI is failing because it's failing to set up 3.9-beta via deadsnakes.

  /usr/bin/python3.9 -mvenv /home/runner/venv-3.9
  Error: Command '['/home/runner/venv-3.9/bin/python3.9', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.
Error: The process '/usr/bin/python3.9' failed with exit code 1

Python 3.9.0 final is now available on GitHub Actions as 3.9.

Let's add that, and we can remove the betas:

  • 3.9.0-beta.4 - 3.9.0 from GHA
  • 3.9-beta from deadsnakes

I left in the 3.8-dev and 3.9-dev dev versions from deadsnakes. Still useful to keep them both?

I also left in the logic for checking -beta, will be useful for when 3.10 reaches beta (or to adapt for alpha). Let me know if you'd prefer it cleaned up.


Also we can see from the above that the single failing job caused all the other jobs to be auto-cancelled:

Instead, we can use fail-fast: false which allows the other jobs to run. For example:

Pull Request Checklist

  • Changes have tests [changes sort of are tests]
  • News fragment added in changelog.d. See documentation for details

@webknjaz
Copy link
Member

I think it's worth adding a misc change note here

# Pre-release versions (GH-shipped)
- os: ubuntu-20.04
python-version: 3.9.0-beta.4 - 3.9.0
# Pre-release versions (deadsnakes)
- os: ubuntu-20.04
python-version: 3.9-beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny that I was just about to submit exactly this change right before seeing your PR. So I ended up sending only the metadata update: #2421.

@webknjaz
Copy link
Member

By the way, the original problem was caused by the upstream bug:
deadsnakes/issues#138 (comment)

@webknjaz
Copy link
Member

@jaraco this PR is clear to be merged w/o any extra reviews. We need to get this done ASAP before anything else in order to fix the CI that makes all of the PR submissions look broken while it's broken because it points to a deadsnakes release that is no longer there.

@jaraco jaraco merged commit 6011043 into pypa:master Oct 17, 2020
0 of 2 checks passed
@hugovk hugovk deleted the add-3.9 branch October 17, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants