Remove bdist_wininst, Filter out distutils deprecation #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
commented
Feb 12, 2021
hroncok
force-pushed
the
remove_bdist_wininst
branch
from
5a151fc
to
8eefd67
Compare
|
@jaraco Is this a way to go for now? |
|
Apologies for letting this linger so long. I’ll try to get to it today. |
jaraco
reviewed
Mar 7, 2021
|
At one point, it was proposed that Setuptools might continue to support bdist_wininst after the removal from Python, or at least it might enable support on Python 3.10+. This approach takes a different tack and accelerates the deprecation and imposes it on older Pythons. I'm okay with that, because those users can still use older Setuptools as a stopgap. |
jaraco
approved these changes
Mar 7, 2021
The distutils platform problems are likely to be resolved before the removal. Once this happens, setuptools will no longer use distutils from the Python standard library.
hroncok
force-pushed
the
remove_bdist_wininst
branch
from
8eefd67
to
5d60cce
Compare
|
Amedned. I've also extended the filterwarnings commit message a bit. |
|
@jaraco Could you please merge this PR? It has been approved 3 weeks ago. |
|
Yes. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Python 3.10.0a5 related fix / workaround. See individual commits.
Closes #2558
Pull Request Checklist
changelog.d/-- not yet