Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the version comparisons #2792

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

DiddiLeija
Copy link
Member

@DiddiLeija DiddiLeija commented Sep 14, 2021

Summary of changes

Closes #2618. Document how the legacy versions and non-legacy versions are compared, and reference to PEP 440.

Pull Request Checklist

Document how the legacy versions and non-legacy versions are compared.
The news entry for my pull request.
@DiddiLeija
Copy link
Member Author

CC @jaraco

@DiddiLeija
Copy link
Member Author

I don't think this will need "tests", right?

@DiddiLeija DiddiLeija changed the title Document the version coparisons Document the version comparisons Sep 14, 2021
Fix some typos.
@DiddiLeija
Copy link
Member Author

@jaraco could you review this pull request please?

Comment on lines +164 to +167
Setuptools can work well with most versioning schemes. Over the years,
setuptools has tried to closely follow the
`PEP 440 <https://www.python.org/dev/peps/pep-0440/>`_ scheme, but it
also supports legacy versions. There are, however, a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should rewrite this paragraph, it sounds a bit weird for me since I made the changes.

@DiddiLeija
Copy link
Member Author

@jaraco can you review this?

@jaraco jaraco merged commit 4cb3544 into pypa:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] version comparison
2 participants