Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging through Python logging module #2974

Merged
merged 2 commits into from Dec 28, 2021
Merged

Enable logging through Python logging module #2974

merged 2 commits into from Dec 28, 2021

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Dec 26, 2021

Summary of changes

Closes #2973. Closes #2023.

Pull Request Checklist

Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a very nice move!

The CI errors seem to be just a hiccup, and pass on the second run

setuptools/__init__.py Show resolved Hide resolved
out_handler.addFilter(_not_warning)
handlers = err_handler, out_handler
logging.basicConfig(
format="{message}", style='{', handlers=handlers, level=logging.DEBUG)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default level is DEBUG instead of INFO or WARNING?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement needed for distutils.log Recommended practice for logging in plugins?
3 participants