Remove more_itertools.more from vendored libs (fixes pypa/setuptools#3090) #3091
Conversation
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
I was inclined to simply accept this change before I realized that it's likely that I'll want to use some of the functionality in more.
I've proposed an alternate approach. WDYT?
tools/vendored.py
Outdated
| """ | ||
| Rewrite more_itertools to remove unused more_itertools.more | ||
| """ | ||
| for more_file in pkg_files.glob("more.py*"): |
There was a problem hiding this comment.
Instead of glob, just use pkg_files.joinpath('more.py') and apply the changes to that.
There was a problem hiding this comment.
The intent was to remove also associated *.pyi files to prevent typechecker (and possibly also smart editors) from believing the removed content is still there
| 'UnequalIterablesError', | ||
| 'adjacent', | ||
| 'all_unique', | ||
| 'always_iterable', |
There was a problem hiding this comment.
I'm expecting to use this function sooner than later as it satisfies a common pattern.
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
maciejp-ro
force-pushed
the
remove-more_itertools.more
branch
from
c8464bf to
44b39e0
Compare
|
I have confirmed that lazy import also fixes gevent freeze, PR updated |
|
Thanks for the fix. Releasing as v60.8.2. |
3 participants
Summary of changes
Remove
more_itertools.morefrom vendoredmore_itertools, which is unused, large, and breaks gevent by importingconcurrent.futures.threading(see gevent/gevent#1865).Closes #3090
Files in vendored
.dist-infodirectory still refer to removed files, I'm assuming it's not a problem because other modifications intools/vendored.pydon't update the checksums.Pull Request Checklist
changelog.d/.(See documentation for details)