Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crashing on build_py errors during editable installs #3506

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

abravalheri
Copy link
Contributor

The #3501 issue seems to represent a class of problems with plugins assuming that build_py don't run during editable installs (as it was the case with the develop command), or that build_py will always copy the files for the temporary build folder.

The idea of this PR is to prevent this class of problems from causing disruption in the environment.

Summary of changes

  • When running build_py during editable installs, capture errors and use a warning to indicate what is the most appropriate migration path.

Closes #3501

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review August 12, 2022 03:44
Copy link
Sponsor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking on this workaround!

@abravalheri abravalheri merged commit 8f2cc1f into pypa:main Aug 12, 2022
@abravalheri abravalheri deleted the issue-3501 branch August 12, 2022 14:11
@abravalheri
Copy link
Contributor Author

Thank you @msarahan for having a look.

yarikoptic added a commit to yarikoptic/datalad that referenced this pull request Aug 12, 2022
https://github.com/datalad/datalad/runs/7793747019?check_suite_focus=true
and others in datalad#6932 are now failing all of a sudden!  Smells the like newest
and greatest setuptools added some deprecation

one more after presumably addresed in setuptools
https://github.com/pypa/setuptools/releases/tag/v64.0.2
pypa/setuptools#3506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PEP-660 editable installs breaks versioneer
2 participants