Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand: Give bytes to ast.parse to let it discover encoding cookie. #3613

merged 3 commits into from Sep 29, 2022


Copy link

@JulienPalard JulienPalard commented Sep 27, 2022

Summary of changes

Closes #3612

Pull Request Checklist

  • Changes have tests

I was able to run my test before/after the patch to ensure it test it.

@JulienPalard JulienPalard force-pushed the mdk-expand branch 2 times, most recently from ae86276 to 7e997ac Compare September 27, 2022 14:21
Copy link

Hi @JulienPalard , thank you very much for working on this.

In other parts of setuptools we use for handling all sorts of encoding. Should it be used here as well?

Copy link
Contributor Author

Does not look needed here, as ast takes care of it.

@jaraco jaraco merged commit 646c71f into pypa:main Sep 29, 2022
10 of 11 checks passed
@JulienPalard JulienPalard deleted the mdk-expand branch September 30, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[BUG] StaticModule not choosing the Python file encoding
3 participants