New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password prompt on upload command #555

Merged
merged 1 commit into from Apr 25, 2016

Conversation

Projects
None yet
2 participants
@brookskindle
Contributor

brookskindle commented Apr 23, 2016

Resolves #554

If there is no password in ~/.pypirc, running the upload command

python setup.py sdist upload

Will now prompt for the user password in the same manner that

python setup.py sdist register

does.


Let me know if I've missed anything or if there is anything that I could change!

I couldn't find any place to document this functionality (ie, in a readme or anything).

Brooks Kindle
Prompt for password on upload.
The upload command wasn't prompting for a password. If there was no
password specified in ~/.pypirc, the upload command,
    python setup.py sdist upload
would fail and raise a TypeError. The workaround for this was to use
    python setup.py sdist register upload
since the register command does prompt for a password.

This commit ensures that the upload command prompts for a password
if not given one by ~/.pypirc or the register command.
@jaraco

This comment has been minimized.

Member

jaraco commented Apr 25, 2016

Thanks!

@jaraco jaraco merged commit 3070dd7 into pypa:master Apr 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment