Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires keywords to setup #631

Merged
merged 3 commits into from Jul 20, 2016

Conversation

@xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Jul 9, 2016

This should allow setuptools to write the metadata Requires-Python and
Requires-External from PEP345 to the PKGINFO file

Looking for validation on the idea before improving it (docs and tests).
Are python_requires and external_requires the right keywords, or should they be requires_python and requires_external ?

This would enable me to revive pypa/pip#3640 using Requires-Python info.

cc @dstufft

@dstufft
Copy link
Member

@dstufft dstufft commented Jul 9, 2016

I don't think I would add the external stuff, I don't think it's generally useful and I think that we would want to avoid shipping that to people since it doesn't have much use.

Totally on board with adding Requires-Python though.

@xavfernandez xavfernandez changed the title [WIP] Add python/external_requires keywords to setup Add python_requires keywords to setup Jul 11, 2016
@xavfernandez
Copy link
Member Author

@xavfernandez xavfernandez commented Jul 11, 2016

external_requires removed and 2 basic tests added.
Feedback welcome :-)

xavfernandez added 3 commits Jul 8, 2016
This should allow setuptools to write the metadata Requires-Python and
Requires-External from PEP345 to the PKGINFO file
@xavfernandez xavfernandez force-pushed the xavfernandez:xfernandez/python_requires branch from 015d291 to 020771f Jul 14, 2016
@xavfernandez
Copy link
Member Author

@xavfernandez xavfernandez commented Jul 14, 2016

@jaraco any feedback ?

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 14, 2016

Why is setuptools rejecting implementation of parts of an accepted PEP ? Should the PEP be edited?

@jaraco
Copy link
Member

@jaraco jaraco commented Jul 14, 2016

I haven't had a chance to review. I'll try to get to it soon. Ping me in a week if you haven't heard anything.

@dstufft
Copy link
Member

@dstufft dstufft commented Jul 14, 2016

@jayvdb Because it was never implemented, will likely be replaced in the future, and is a needless footgun.

@jaraco
Copy link
Member

@jaraco jaraco commented Jul 20, 2016

Looks good to me. Let's give it a go.

@jaraco jaraco merged commit b2f50d5 into pypa:master Jul 20, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavfernandez
Copy link
Member Author

@xavfernandez xavfernandez commented Jul 21, 2016

Oh
Happy to see it merged, but it looks like I did not push my latest change for the Metadata-Version update, I'll push it via an other PR in an hour.

@xavfernandez xavfernandez deleted the xavfernandez:xfernandez/python_requires branch Jul 21, 2016
brechtm added a commit to brechtm/rinohtype that referenced this pull request Aug 11, 2016
In the future, this will prevent installation on unsupported Python
versions (pypa/setuptools#631).
rgommers added a commit to rgommers/numpy that referenced this pull request Apr 15, 2017
This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
rgommers added a commit to rgommers/scipy that referenced this pull request Apr 18, 2017
This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
perimosocordiae added a commit to scipy/scipy that referenced this pull request Apr 18, 2017
)

This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants