New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuation line unaligned for hanging indent. #663

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Jul 21, 2016

No description provided.

@@ -85,7 +85,7 @@ def install_namespaces(self):
"p = os.path.join(sys._getframe(1).f_locals['sitedir'], *%(pth)r)",
"ie = os.path.exists(os.path.join(p,'__init__.py'))",
"m = not ie and "
"sys.modules.setdefault(%(pkg)r, types.ModuleType(%(pkg)r))",
"sys.modules.setdefault(%(pkg)r, types.ModuleType(%(pkg)r))",

This comment has been minimized.

@jaraco

jaraco Jul 21, 2016

Member

This line was intentionally indented to give a visual cue that this string is a continuation of the previous one, and not just another string in the list. Without that cue, it would be an easy mistake to miss the lack of a comma.

@@ -823,7 +823,7 @@ class Feature:
def warn_deprecated():
warnings.warn(
"Features are deprecated and will be removed in a future "
"version. See https://github.com/pypa/setuptools/issues/65.",
"version. See https://github.com/pypa/setuptools/issues/65.",

This comment has been minimized.

@jaraco

jaraco Jul 21, 2016

Member

Same issue here.

@ghost

This comment has been minimized.

ghost commented Jul 21, 2016

@jaraco Fixed.

@jaraco jaraco merged commit 0cd550a into pypa:master Jul 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment