New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging using arguments instead of formatter #717

Merged
merged 1 commit into from Aug 4, 2016

Conversation

Projects
None yet
2 participants
@vallsv
Contributor

vallsv commented Aug 3, 2016

Hi. While i was working around setuptools, here is very small clean up about code quality.
In case you take care of it.
Regards

@@ -1038,8 +1038,7 @@ def open_with_auth(url, opener=urllib.request.urlopen):
cred = PyPIConfig().find_credential(url)
if cred:
auth = str(cred)
info = cred.username, url
log.info('Authenticating as %s for %s (from .pypirc)' % info)
log.info('Authenticating as %s for %s (from .pypirc)', cred.username, url)

This comment has been minimized.

@jaraco

jaraco Aug 4, 2016

Member

I think this line is now too long.

@jaraco jaraco merged commit 5129feb into pypa:master Aug 4, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jaraco

This comment has been minimized.

Member

jaraco commented Aug 4, 2016

The rest of the changes are great, so I'll take the good with the bad. Thanks.

@vallsv

This comment has been minimized.

Contributor

vallsv commented Aug 4, 2016

you can use *info if you prefer. I can send a patch.

@vallsv

This comment has been minimized.

Contributor

vallsv commented Aug 4, 2016

Oh it is already done :-D
Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment