Fix logging using arguments instead of formatter #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1038,8 +1038,7 @@ def open_with_auth(url, opener=urllib.request.urlopen): | |||
| cred = PyPIConfig().find_credential(url) | |||
| if cred: | |||
| auth = str(cred) | |||
| info = cred.username, url | |||
| log.info('Authenticating as %s for %s (from .pypirc)' % info) | |||
| log.info('Authenticating as %s for %s (from .pypirc)', cred.username, url) | |||
There was a problem hiding this comment.
I think this line is now too long.
|
The rest of the changes are great, so I'll take the good with the bad. Thanks. |
|
you can use |
|
Oh it is already done :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. While i was working around setuptools, here is very small clean up about code quality.
In case you take care of it.
Regards