Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert library_dir_option patch. #725

Merged
merged 1 commit into from Aug 5, 2016
Merged

revert library_dir_option patch. #725

merged 1 commit into from Aug 5, 2016

Conversation

@JGoutin
Copy link
Contributor

@JGoutin JGoutin commented Aug 5, 2016

Revert patch on distutils._msvccompiler.MSVCCompiler.library_dir_option.

See comments on #694.

Revert patch on `distutils._msvccompiler.MSVCCompiler.library_dir_option`

See comments on #694.
@jaraco jaraco merged commit 0676d04 into pypa:master Aug 5, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JGoutin JGoutin deleted the JGoutin:patch-1 branch Aug 5, 2016
@anthrotype
Copy link

@anthrotype anthrotype commented Aug 5, 2016

Thanks. I tried again to build brotli from my local Windows machine (Python35-x86) using the latest setuptools tag v25.1.6, and it finally works.
This time, I made sure the correct setuptools was imported before I can say "it works". Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants