Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file for expectant auditors #730

Merged
merged 1 commit into from Aug 12, 2016

Conversation

@sigmavirus24
Copy link
Member

@sigmavirus24 sigmavirus24 commented Aug 12, 2016

The classifier in setup.py should be enough for most auditors, but some
have automated tooling that checks for LICENSE files and reads those.
This helps all auditors (downstream redistributors and users) who can
not just rely on the classifier.

Related to #612

@sigmavirus24
Copy link
Member Author

@sigmavirus24 sigmavirus24 commented Aug 12, 2016

Ah, forgot the changelog entry.

@sigmavirus24 sigmavirus24 force-pushed the sigmavirus24:add-license-file branch from 7d395b7 to 448d925 Aug 12, 2016
CHANGES.rst Outdated
@@ -6,6 +6,8 @@ v25.1.6
-------

* #725
* #612 via #730: Add a LICENSE file which neds to be provided by the terms of

This comment has been minimized.

This comment has been minimized.

@jaraco

jaraco Aug 12, 2016
Member

Also, this entry should go in a new section for v25.2.0.

This comment has been minimized.

@sigmavirus24

sigmavirus24 Aug 12, 2016
Author Member

Done & done.

The classifier in setup.py should be enough for most auditors, but some
have automated tooling that checks for LICENSE files and reads those.
This helps all auditors (downstream redistributors and users) who can
not just rely on the classifier.

Related to #612
@sigmavirus24 sigmavirus24 force-pushed the sigmavirus24:add-license-file branch from 448d925 to 8383954 Aug 12, 2016
@jaraco jaraco merged commit ee5f841 into pypa:master Aug 12, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sigmavirus24 sigmavirus24 deleted the sigmavirus24:add-license-file branch Aug 12, 2016
@jakirkham
Copy link
Contributor

@jakirkham jakirkham commented Aug 15, 2016

Do you think there is any value to having a .txt extension for the license? There seem to be many authors that do this. Particularly to ensure that Windows is able to open this file correctly.

@sigmavirus24
Copy link
Member Author

@sigmavirus24 sigmavirus24 commented Aug 15, 2016

@jakirkham not really? Almost every project I've ever seen has had the license file sans .txt.

@jakirkham
Copy link
Contributor

@jakirkham jakirkham commented Aug 15, 2016

Just to provide some examples, NumPy does. Similarly so does SciPy and Cython. If one looks around a bit, one can find many more examples. Though it is true there are examples without the extension.

@sigmavirus24
Copy link
Member Author

@sigmavirus24 sigmavirus24 commented Aug 15, 2016

Yeah, we can both dig up numerous examples either way both inside and outside of the Python ecosystem. I don't think it really matters and this (merged) pull request certainly isn't the place for a discussion of this type (whether or not to put .txt at the end of a LICENSE file name because some operating systems do weird things in an attempt to be smart).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants