Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.3.0 for extension suffix #837

Merged
merged 2 commits into from Nov 4, 2016

Conversation

@reaperhulk
Copy link
Contributor

@reaperhulk reaperhulk commented Nov 3, 2016

In setuptools 27.0+ extension building fails on Python 3.3.0 because the extension suffix is obtained using SO and not EXT_SUFFIX (which is used in 3.3.1 and above). See: https://hg.python.org/cpython/file/v3.3.0/Lib/distutils/command/build_ext.py#l673

This patch tries EXT_SUFFIX and falls back to SO if EXT_SUFFIX is falsey.

reaperhulk added 2 commits Nov 3, 2016
In setuptools 27.0+ extension building fails on Python 3.3.0 because the extension suffix is obtained using `SO` and not `EXT_SUFFIX` (which is used in 3.3.1 and above). See: https://hg.python.org/cpython/file/v3.3.0/Lib/distutils/command/build_ext.py#l673

This patch tries `EXT_SUFFIX` and falls back to `SO` if `EXT_SUFFIX` is falsey.
@jaraco
Copy link
Member

@jaraco jaraco commented Nov 4, 2016

This seems all fine and good.

But it also feels like some undocumented cruft that will linger long after it's needed. Imagine your future self looking at this code and wondering, "why does it grab a value from one of two different places? Under what circumstances will EXT_SUFFIX return Falsey?"

This change is the kind that I like to wrap in some sort of wrapper to explain its purpose and when its purpose will no longer be needed. I'll go ahead and add that here.

@jaraco jaraco merged commit 9ddf208 into pypa:master Nov 4, 2016
2 checks passed
jaraco added a commit that referenced this issue Nov 4, 2016
@reaperhulk
Copy link
Contributor Author

@reaperhulk reaperhulk commented Nov 6, 2016

@jaraco Looks good, thanks for taking this and making it better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants