Remove _add_defaults_data_files override and add unittest #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tweksteen: Would you consider augmenting this pull request to specifically detect the case where non-standard values are being passed for data_files, log an error, and omit the files? That way, for this rare case, setuptools will continue to work as it did before, but for everything else it will work fine. The warning message will also provide incentive to the offending packages to correct their behavior. |
tweksteen
force-pushed
the
pypi_tests
branch
from
3494d62
to
0235d8e
Compare
tweksteen
force-pushed
the
pypi_tests
branch
from
0235d8e
to
11b921f
Compare
|
Agreed and done. Let me know if the warning message is clear enough. (Also, should |
|
Looks good. And after fixing the test failures due to other flux in the ecosystem, the PR tests are passing. I'm prepared to accept. |
jaraco
added a commit
that referenced
this pull request
Dec 1, 2016
|
I spoke too soon. The tests for Python 3.7 are failing. |
jaraco
added a commit
that referenced
this pull request
Dec 1, 2016
…n Python 2 where old style classes are used. Ref #843.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening a pull request similar to PR #830. I've included unit test for that specific feature.
The only noticeable package that will fail with this patch is django_compressor because of dependencies on rcssmin and rjsmin. The main author has been contacted and is aware of the issue. It is best to organise a meaningful timeline with him to fix his issues before merging this PR.