Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_index: fix bug not catching some network timeouts #846

Merged
merged 1 commit into from Dec 3, 2016

Conversation

Projects
None yet
2 participants
@jmuchemb
Copy link
Contributor

jmuchemb commented Nov 13, 2016

There are already so many exceptions catched, like socket errors (e.g. failure in name resolution) or HTTP errors. Depending on when a timeout occurs, it is either catched (URLError during the SSL handshake) or not (socket.error while getting a HTTP response).

When used by buildout, this fixes random failures when running in newest mode (which is the default case), or when the requested version is available in the download-cache.

package_index: fix bug not catching some network timeouts
There are already so many exceptions catched, like socket errors (e.g. failure
in name resolution) or HTTP errors. Depending on when a timeout occurs, it is
either catched (URLError during the SSL handshake) or not (socket.error while
getting a HTTP response).

When used by buildout, this fixes random failures when running in newest mode
(which is the default case), or when the requested version is available in the
download-cache.

@jaraco jaraco merged commit 5358117 into pypa:master Dec 3, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jaraco added a commit that referenced this pull request Dec 3, 2016

@jmuchemb jmuchemb deleted the jmuchemb:pkg-idx-timeout branch Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.