strip trailing slash from package_dir before counting slashes #913
Hi! Apologies, wasn't sure of your process so figured i'd just throw this over the wall and see what response, if any it provoked.
I was getting
It looks like the edited code is using slashes as a heuristic for how far up the tree to walk, and i guessed that it might be getting confused by the trailing slash
unfortunately i'm new to this codebase, so was hoping for some guidance from yourself or some other core dev as to other (potentially bad) implications of this change, as well as how to best test it
I figured it was something like that. Thanks for providing the background. It sure would be nice to have a test for this - I'm not sure where it would go, if it should be a test for the develop command, or for the package_dir values. The fix also should consider non-Unix paths. Perhaps the whole routine should be written to use