New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dist-info distributions inside zip files #966

Merged
merged 1 commit into from Feb 12, 2017

Conversation

Projects
None yet
2 participants
@daa
Contributor

daa commented Feb 10, 2017

I had a problem when pkg_resources.get_distribution() didn't work inside executable zip, and I've found that it doesn't work for packages inside zip archives mentioned in sys.path. So this pull request adds support for such cases.

@jaraco

This comment has been minimized.

Member

jaraco commented Feb 12, 2017

Thanks for the contrib.

While I can see how this behavior is desirable, I feel a bit uncomfortable with the placement. The function it's in is called find_eggs_in_zip, and this function isn't finding eggs. I also see other apparently inappropriately-named functions like _is_unpacked_egg which doesn't seem to check anything about packing. Looking at it more, I think I understand why this implementation is correct, and there's nothing about what you've written that's improper, but the expanded scope is making the function name less appropriate.

Overall, I think the benefits outweigh the issues, and indeed it's probably best if structural issues like these are addressed by the package maintainers, so let's go with it.

@jaraco jaraco merged commit aae0a92 into pypa:master Feb 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jaraco added a commit that referenced this pull request Feb 12, 2017

@daa daa deleted the daa:zipfile-dist-info branch Feb 13, 2017

@daa

This comment has been minimized.

Contributor

daa commented Feb 13, 2017

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment