Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A local version label starts with a '+' sign #968

Merged

Conversation

@moriyoshi
Copy link
Contributor

@moriyoshi moriyoshi commented Feb 11, 2017

As per https://www.python.org/dev/peps/pep-0440/#local-version-identifiers:

Local version identifiers MUST comply with the following scheme:

<public version identifier>[+<local version label>]

But EGG_FRAGMENT's character set does not contain the plus sign, which seems to be a defect.

@moriyoshi moriyoshi changed the title A local version label starts with '+' sign A local version label starts with a '+' sign Feb 11, 2017
@jaraco
Copy link
Member

@jaraco jaraco commented Feb 11, 2017

This looks good to me. If you add an entry to the CHanges.rst file, that'll save me time getting this out. Probably us an 0.1 bump. Thanks.

@moriyoshi
Copy link
Contributor Author

@moriyoshi moriyoshi commented Feb 12, 2017

I found '!' also needs to be accepted on a further investigation:

https://www.python.org/dev/peps/pep-0440/#public-version-identifiers

The canonical public version identifiers MUST comply with the following scheme:

[N!]N(.N)*[{a|b|rc}N][.postN][.devN]

https://github.com/pypa/packaging/blob/master/packaging/specifiers.py#L301

@moriyoshi moriyoshi force-pushed the moriyoshi:moriyoshi/local-version-label-in-egg-fragment branch from 34f6eeb to f33cfac Feb 12, 2017
@jaraco
Copy link
Member

@jaraco jaraco commented Feb 13, 2017

Brilliant. I love it.

@jaraco jaraco merged commit 8ed00a7 into pypa:master Feb 13, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants