Skip to content

Add reStructuredText markup classifier. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Add reStructuredText markup classifier. #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06aa0c5
Add reStructuredText markup classifier.
kdeldycke Sep 3, 2020
341b6e0
Fix black formatting.
kdeldycke Sep 3, 2020
fd7a112
Sorting is case-sensitive.
kdeldycke Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/trove_classifiers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@
"Topic :: Text Processing :: Markup :: SGML",
"Topic :: Text Processing :: Markup :: VRML",
"Topic :: Text Processing :: Markup :: XML",
"Topic :: Text Processing :: Markup :: reStructuredText",
"Topic :: Utilities",
"Typing :: Typed",
}
Expand Down
40 changes: 33 additions & 7 deletions tests/test_classifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@
@pytest.mark.parametrize(
"classifiers, deprecated_classifiers",
[
({"Foo :: Bar", "Foo :: Bar :: Baz",}, {}),
(
{
"Foo :: Bar",
"Foo :: Bar :: Baz",
},
{},
),
({"Foo :: Bar"}, {"Biz :: Baz": ["Foo :: Bar"]}),
],
)
Expand All @@ -17,15 +23,23 @@ def test_success(classifiers, deprecated_classifiers):
@pytest.mark.parametrize(
"classifiers, deprecated_classifiers, expected",
[
({"Foo", "Foo :: Bar"}, {}, "Top-level classifier 'Foo' is invalid",),
(
{"Foo", "Foo :: Bar"},
{},
"Top-level classifier 'Foo' is invalid",
),
({"Foo :: Bar :: Baz"}, {}, "Classifier 'Foo :: Bar' is missing"),
(
{"Foo :: Bar",},
{
"Foo :: Bar",
},
{"Biz :: Baz": ["Bing :: Bang"]},
"Classifier 'Bing :: Bang' does not exist",
),
(
{"Foo :: Bar",},
{
"Foo :: Bar",
},
{"Foo :: Bar": []},
"Classifier 'Foo :: Bar' in both valid and deprecated classifiers",
),
Expand All @@ -43,9 +57,21 @@ def test_success(classifiers, deprecated_classifiers):
{},
"Classifiers starting or ending with whitespace are invalid",
),
({"Foo: :: Bar"}, {}, "Classifiers containing ':' are invalid",),
({"Foo :: B:ar"}, {}, "Classifiers containing ':' are invalid",),
({"Foo :: Bar: Baz"}, {}, "Classifiers containing ':' are invalid",),
(
{"Foo: :: Bar"},
{},
"Classifiers containing ':' are invalid",
),
(
{"Foo :: B:ar"},
{},
"Classifiers containing ':' are invalid",
),
(
{"Foo :: Bar: Baz"},
{},
"Classifiers containing ':' are invalid",
),
],
)
def test_failure(classifiers, deprecated_classifiers, expected):
Expand Down