Skip to content

Commit

Permalink
Log warning for skipped packages
Browse files Browse the repository at this point in the history
  • Loading branch information
bhrutledge committed Feb 27, 2022
1 parent 93688ae commit 2d80aea
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions twine/commands/upload.py
Expand Up @@ -129,15 +129,14 @@ def upload(upload_settings: settings.Settings, dists: List[str]) -> None:

for package in packages_to_upload:
skip_message = (
f"[yellow]Skipping {package.basefilename}"
" because it appears to already exist"
f"Skipping {package.basefilename} because it appears to already exist"
)

# Note: The skip_existing check *needs* to be first, because otherwise
# we're going to generate extra HTTP requests against a hardcoded
# URL for no reason.
if upload_settings.skip_existing and repository.package_is_uploaded(package):
print(skip_message)
logger.warning(skip_message)
continue

resp = repository.upload(package)
Expand All @@ -156,7 +155,7 @@ def upload(upload_settings: settings.Settings, dists: List[str]) -> None:
)

if skip_upload(resp, upload_settings.skip_existing, package):
print(skip_message)
logger.warning(skip_message)
continue

utils.check_status_code(resp, upload_settings.verbose)
Expand Down

0 comments on commit 2d80aea

Please sign in to comment.