Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take repository URL form the commandline. #166

Closed
wants to merge 2 commits into from

Conversation

jankatins
Copy link
Contributor

@jankatins jankatins commented Feb 4, 2016

To make usage of twine within a CI setup easier, make it possible to
run twin without a pypirc file. This commit adds the possibility to
specify the repository URL directly on the commandline.

This is done by overloading the --repository switch: this can now be
a section in the pypirc file (as before) or a full URL (e.g. something
with :// in it).

Note that this is only needed when you don't want to upload to PyPI,
for PyPI we already have a fallback in place.

Closes: #143

To make usage of twin within a CI setup easier, make it possible to
run twin without a pypirc file. This commit adds the possibility to
specify the repository URL directly on the commandline.

This is done by overloading the `--repository` switch: this can now be
a section in the pypirc file (as before) or a full URL (e.g. something
with `://` in it).

Note that this is only needed when you don't want to upload to PyPI,
for PyPI we already have a fallback in place.
@jankatins
Copy link
Contributor Author

Fixed all test but this one:

https://travis-ci.org/pypa/twine/jobs/128574414

$ tox
GLOB sdist-make: /home/travis/build/pypa/twine/setup.py
docs create: /home/travis/build/pypa/twine/.tox/docs
docs installdeps: sphinx, releases
docs inst: /home/travis/build/pypa/twine/.tox/dist/twine-1.6.5.zip
docs installed: alabaster==0.7.8,args==0.1.0,Babel==2.3.4,clint==0.5.1,docutils==0.12,imagesize==0.7.1,Jinja2==2.8,MarkupSafe==0.23,pkginfo==1.2.1,Pygments==2.1.3,pytz==2016.4,releases==1.1.0,requests==2.10.0,requests-toolbelt==0.6.1,semantic-version==2.5.0,six==1.10.0,snowballstemmer==1.2.1,Sphinx==1.4.1,twine==1.6.5
docs runtests: PYTHONHASHSEED='4068678425'
docs runtests: commands[0] | sphinx-build -W -b html -d /home/travis/build/pypa/twine/.tox/docs/tmp/doctrees docs docs/_build/html
Running Sphinx v1.4.1
making output directory...
loading pickled environment... not yet created
Theme error:
sphinx_rtd_theme is no longer a hard dependency since version 1.4.0. Please install it manually.
ERROR: InvocationError: '/home/travis/build/pypa/twine/.tox/docs/bin/sphinx-build -W -b html -d /home/travis/build/pypa/twine/.tox/docs/tmp/doctrees docs docs/_build/html'
___________________________________ summary ____________________________________
ERROR:   docs: commands failed

@mmellison
Copy link

This would make things much more simple for us in CI - it's cumbersome to have to write out a .pypirc every time we want to use twine!

Any chance of someone taking a look at this? Looks like all the tests passed, just the docs failed to build.

@sigmavirus24
Copy link
Member

Any chance of someone taking a look at this? Looks like all the tests passed, just the docs failed to build.

Soon, @seglberg. I'm quite busy right now, but a new release of twine with this feature is slated for the next month or so.

sigmavirus24 added a commit to sigmavirus24/twine that referenced this pull request Aug 3, 2016
This refactors the work in pypagh-166 a bit and adds a new command-line
flag to enable the behaviour.

Supersedes pypagh-166
@sigmavirus24
Copy link
Member

I've resolved the merge conflicts and pulled this into #203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants