New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyPy linter is broken in tox and Travis CI ignores this #439
Comments
The output of the Line 42 in ff475aa
|
Yep, and further investigation has shown that at the time this line was added (https://github.com/pypa/twine/pull/380/files#diff-b91f3d5bd63fcd17221b267e851608e8L42) mypy was at version of So because it was completely ignored nobody noticed when after warning period that arg was removed completely. I'm working on a Travis CI improvement PR and I'm going to separate mypy into a separate check to improve visibility. |
Ref #440 |
This is entirely by design that it was ignored. |
Well, at least it'll be less broken now |
I mean it's fine that it's ignored but it's done on the wrong level which caused it to become invisibly broken. |
* Use mapping syntax for declaring env in Travis CI * Add a Travis CI badge to README * Fail fast in Travis CI * Move default toxenv spec to global env * Reorder jobs in Travis CI * Linters and docs first * Latest Pythons of all flavours * Everything else * Add names to linting jobs * Add Travis CI link to project urls meta * Fix pyblake2 installation conditional in tox * Fix broken mypy command in tox Closes #439 * Reorder envs in tox to match Travis CI order * Move mypy check into separate job allowed to fail * Set env marker for pyblake2 to check interpreter * Split the rest of linters into dist vs code checks * Post code coverage even from failed jobs * Fix lint envs list * Add a lint testenv alias to tox * Put only one lint env into default envlist
Failed mypy command still produces a green build.
Demo: https://travis-ci.org/pypa/twine/jobs/465465836#L591-L594
The text was updated successfully, but these errors were encountered: