Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyring support #408

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
5 participants
@di
Copy link
Member

commented Oct 1, 2018

Per this comment, fix a regression from #395 that would never successfully import keyring. A full explanation as to why this needed changed is in 3ae98ed.

Thanks to @adamtheturtle for catching it.

@codecov

This comment has been minimized.

Copy link

commented Oct 1, 2018

Codecov Report

Merging #408 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   77.99%   78.08%   +0.09%     
==========================================
  Files          14       14              
  Lines         727      730       +3     
  Branches      104      104              
==========================================
+ Hits          567      570       +3     
  Misses        128      128              
  Partials       32       32
Impacted Files Coverage Δ
twine/utils.py 84% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e88ce...5e80bfa. Read the comment docs.

@theacodes theacodes merged commit 360401b into pypa:master Oct 1, 2018

3 checks passed

codecov/patch 100% of diff hit (target 77.99%)
Details
codecov/project 78.08% (+0.09%) compared to 49e88ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adamtheturtle

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2018

Thank you @di and @theacodes - a release with this fix would be appreciated - is there anything I can do to help with that?

@jaraco

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

This issue bit me today. I don't often release locally, but when I do, I do rely on keyring. I'll see if I can cut a release.

jaraco added a commit that referenced this pull request Oct 14, 2018

@jaraco

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

I've updated the changelog and version, following patterns from prior commits, and tagged that commit. Unfortunately, I don't have access to upload to PyPI. Would @dstufft or @brainwane or @sigmavirus24 be willing to cut a release? Alternatively, add me to PyPI maintainers if you'd like me to upload the release.

@di di deleted the di:fix-keyring-support branch Oct 14, 2018

@di

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2018

@sigmavirus24

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@jaraco I'd also ask that you not push changes to this project like you've done. PRs are the project's preferred way of working. You pushed release notes that were premature

@jaraco

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

@sigmavirus24 My mistake. I was working from the assumption that I had access to help cut releases, so I was seeking to do just that. Since nothing had changed between the last release and this bugfix, it seemed like a low risk bugfix release and I was seeking to get it out. I'll back out the changelog and delete the tag.

I was affected by this bug again today. It would be nice to get a fix out.

@jaraco jaraco referenced this pull request Nov 5, 2018

Closed

Keyring support broken #423

jaraco added a commit that referenced this pull request Jan 4, 2019

Merge pull request #413 from jaraco/backout/1.12.2
Revert "Update changelog and bump version. Ref #408."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.