Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shutil for rmtree #763

Merged
merged 1 commit into from Jun 12, 2021
Merged

Use shutil for rmtree #763

merged 1 commit into from Jun 12, 2021

Conversation

@bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Jun 12, 2021

A bit of bikeshedding, but it looks like this does the same thing, without needing an extra dependency.

https://docs.python.org/3/library/shutil.html#shutil.rmtree

@bhrutledge bhrutledge requested a review from jaraco Jun 12, 2021
jaraco
jaraco approved these changes Jun 12, 2021
Copy link
Member

@jaraco jaraco left a comment

This looks good. I'm unsure why I didn't consider this option. Perhaps I attempted a pathlib solution and it didn't have the functionality, so I fell back to path. Ideally, this change should be made in jaraco/skeleton and merged here. I'll cherry-pick the commit so that's possible.

Loading

@jaraco
Copy link
Member

@jaraco jaraco commented Jun 12, 2021

Oh, I see this project isn't merged with jaraco/skeleton. Still, I applied the change at jaraco/skeleton@5a8384e.

Loading

@bhrutledge bhrutledge merged commit 12469ce into pypa:master Jun 12, 2021
23 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants