Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send only the digests we have from PackageFile #776

Merged
merged 2 commits into from Jul 16, 2021
Merged

Send only the digests we have from PackageFile #776

merged 2 commits into from Jul 16, 2021

Conversation

@sigmavirus24
Copy link
Member

@sigmavirus24 sigmavirus24 commented Jul 15, 2021

Once again, we have to deal with third-party package repositories doing
their own thing and users needing this to just work. Those repositories
combined with FIPS mean that we will need to send the information we
actually have and only that when it comes to digests.

Closes gh-775

Once again, we have to deal with third-party package repositories doing
their own thing and users needing this to just work. Those repositories
combined with FIPS mean that we will need to send the information we
actually have and only that when it comes to digests.

Closes gh-775
@bhrutledge bhrutledge self-requested a review Jul 15, 2021
@bhrutledge bhrutledge removed their assignment Jul 15, 2021
Copy link
Contributor

@bhrutledge bhrutledge left a comment

Thanks for the quick work on this. I think I follow, and have made some suggestions for clarity.

Loading

tests/test_package.py Outdated Show resolved Hide resolved
Loading
twine/package.py Outdated Show resolved Hide resolved
Loading
Let's be clearer about some of the bizarre logic we use to support 
repositories other than PyPI and distributions using FIPS

Co-authored-by: Brian Rutledge <bhrutledge@gmail.com>
Copy link
Contributor

@bhrutledge bhrutledge left a comment

Thank you!

Loading

@bhrutledge bhrutledge merged commit fc20d94 into main Jul 16, 2021
43 checks passed
Loading
@bhrutledge bhrutledge deleted the bug/775 branch Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants