Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass StringIO for _WarningStream. #886

Merged
merged 1 commit into from Mar 31, 2022

Conversation

bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Mar 26, 2022

Resolves #884.

This is responding to a change in readme_renderer.rst.render that expects an IO[str] instance. See discussion at pypa/readme_renderer#231 (review).

Requesting review from @di as a maintainer of both projects. Also FYI @miketheman.

This is responding to a change in readme_renderer.rst.render that
expects an `IO[str]` instance. See discussion at
pypa/readme_renderer#231 (review)
@bhrutledge bhrutledge added this to the 4.0.0 milestone Mar 26, 2022
@bhrutledge bhrutledge requested a review from di Mar 26, 2022
Copy link

@miketheman miketheman left a comment

This looks like it'll do the trick!
I reviewed that the changes in the test module don't change the test output, only how they are called.

@bhrutledge bhrutledge merged commit 7cd0b23 into pypa:main Mar 31, 2022
21 checks passed
@bhrutledge bhrutledge deleted the 884-readme-warnings branch Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants