New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom bootstrap script does not contain extra_text #1244

Closed
rinrinne opened this Issue Nov 13, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@rinrinne
Copy link

rinrinne commented Nov 13, 2018

Below is how to create custom bootstrap script.
https://virtualenv.pypa.io/en/latest/reference/#creating-your-own-bootstrap-scripts

But created script does not contain extra_text with virtualenv 16.1.0 and master.

$ python -c "import virtualenv; print(virtualenv.create_bootstrap_script('HELLOWORLD'))"| grep HELLOWORLD
$

Seems expected bootstrap script can be created with virtualenv 16.0.0

$ python -c "import virtualenv; print(virtualenv.create_bootstrap_script('HELLOWORLD'))"| grep HELLOWORLD
HELLOWORLD
$
@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Dec 24, 2018

Thanks for this report, I'll address this.

@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Dec 25, 2018

@rinrinne this now has been fixed inside the master and will roll out in a few days with 16.2.

gaborbernat added a commit that referenced this issue Dec 25, 2018

gaborbernat added a commit that referenced this issue Dec 25, 2018

@rinrinne

This comment has been minimized.

Copy link

rinrinne commented Dec 26, 2018

Thanks! Confirmed as expected on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment