Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selftesting fails on openSUSE #1721

Closed
scarabeusiv opened this issue Mar 13, 2020 · 5 comments · Fixed by #1731
Closed

selftesting fails on openSUSE #1721

scarabeusiv opened this issue Mar 13, 2020 · 5 comments · Fixed by #1731
Labels

Comments

@scarabeusiv
Copy link

@scarabeusiv scarabeusiv commented Mar 13, 2020

When building updated package for 2.0.10 the test_create_no seed with some options fails on python3 (seem not to be run under py2):

[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[root-venv-copies-isolated]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[root-venv-copies-global]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[root-venv-symlinks-isolated]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[root-venv-symlinks-global]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[venv-venv-copies-isolated]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[venv-venv-copies-global]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[venv-venv-symlinks-isolated]
[  158s] FAILED tests/unit/create/test_creator.py::test_create_no_seed[venv-venv-symlinks-global]

Full build log:
buildlog.txt

Also there are 4 build failures on both py2 and py3:

[   77s] FAILED tests/unit/create/test_creator.py::test_create_distutils_cfg[cpython2-posix]
[   77s] FAILED tests/unit/create/test_interpreters.py::test_failed_to_find_implementation[/usr/bin/python2]
[   77s] FAILED tests/unit/discovery/py_info/test_py_info.py::test_py_info_cache_clear
[   77s] FAILED tests/unit/discovery/py_info/test_py_info.py::test_py_info_cached_symlink

Full build log of that one (previous one has them skipped to see the other ones):
buildlog.txt

Any idea if there is something really borked or if it is safe to ignore these in our build enviroment?

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Mar 13, 2020

@scarabeusiv seems like an actual valid failure; do you have a docker image that replicates? What openSuse is this?

@scarabeusiv
Copy link
Author

@scarabeusiv scarabeusiv commented Mar 13, 2020

It is the rolling release one, Tumbleweed.
If you go for dockerfile the FROM opensuse/tumbleweed should be enough.

Also I have the package in OBS: https://build.opensuse.org/package/show/devel:languages:python/python-virtualenv

And if you can get your hands on 'osc' tool you can from commandline try to trigger the build and chroot to the virtual machine used by the OBS itself (sadly one needs to have user account to do that):

osc co devel:languages:python/python-virtualenv
cd devel:languages:python/python-virtualenv
osc build -M test
osc chroot
cd /home/abuild/rpmbild/BUILD/python-virtualenv*/
pytest-3.8 -vv

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Mar 18, 2020

@scarabeusiv see #1731 for a docker file that now passes, will merge and release right now

@scarabeusiv
Copy link
Author

@scarabeusiv scarabeusiv commented Mar 19, 2020

Thanks, I can confirm now it passes and I've sent the 2.0.11 for the distro integration.

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Mar 19, 2020

Hello, a fix for this issue has been released via virtualenv 20.0.11; see https://pypi.org/project/virtualenv/20.0.11/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-11-2020-03-18). Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release.
thanks

bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this issue Apr 19, 2020
https://build.opensuse.org/request/show/794520
by user scarabeus_iv + dimstar_suse
- Update to 20.0.17:
  * minor fixes
  * update of embedded modules

- Update to 20.0.11:
  - Allow the test suite to pass even when called with the system Python - to help repackaging of the tool for Linux
    distributions -  by :user:`gaborbernat`. (`#1721 <https://github.com/pypa/virtualenv/issues/1721>`_)
  - Other minor fixes

- Update to 20.0.10:
  * Complete rewrite and redesign of the virtualenv package
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants